Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to allow install for arm64 darwin. #1148

Merged
merged 5 commits into from
Jun 27, 2023

Conversation

kbuma
Copy link
Contributor

@kbuma kbuma commented Jun 13, 2023

Fixes/Addresses:

#1100

Summary/Motivation:

Allows users of MacOs on Apple silicon to install and run FOQUS.

Changes proposed in this PR:

  • update to setup.py to exclude PyQt5 install on these machines
  • documentation of steps required to install on these machines (once we have the next release out we can remove the need to download source as part of this)

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@kbuma kbuma requested a review from lbianchi-lbl June 13, 2023 23:19
@kbuma kbuma self-assigned this Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ceb1e46) 37.23% compared to head (7cb8595) 37.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   37.23%   37.23%           
=======================================
  Files         160      160           
  Lines       36343    36343           
  Branches     5944     5944           
=======================================
  Hits        13531    13531           
  Misses      21730    21730           
  Partials     1082     1082           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbianchi-lbl lbianchi-lbl linked an issue Jun 20, 2023 that may be closed by this pull request
@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Jun 20, 2023
@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) June 20, 2023 20:27
@kbuma
Copy link
Contributor Author

kbuma commented Jun 25, 2023

@lbianchi-lbl it looks like the py3.9 tests are no longer passing and that's blocking this from being merged.

I don't think it's due to this change: I ran the tests on my developer machine and I'm getting the same behavior for the 3.17.1 release. I don't know enough about the tests to be able to tell why. Maybe new versions of some dependencies?

@lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl it looks like the py3.9 tests are no longer passing and that's blocking this from being merged.

I don't think it's due to this change: I ran the tests on my developer machine and I'm getting the same behavior for the 3.17.1 release. I don't know enough about the tests to be able to tell why. Maybe new versions of some dependencies?

Yeah, my best guess is NumPy: #1151

@lbianchi-lbl lbianchi-lbl merged commit 74b3f6e into CCSI-Toolset:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOQUS fails to install on Apple M1/ARM platforms
2 participants