Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve test failures due to NumPy 1.25 #1152

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

Resolves #1151

(replace this with the issue # fixed or addressed, if no issue exists then a brief statement of what this PR does)

Summary/Motivation:

Changes proposed in this PR:

  • Add an isinstance() check before comparing with empty string to avoid NumPy error

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d70d4f5) 37.23% compared to head (fb70738) 37.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1152   +/-   ##
=======================================
  Coverage   37.23%   37.23%           
=======================================
  Files         160      160           
  Lines       36343    36343           
  Branches     5944     5944           
=======================================
  Hits        13531    13531           
  Misses      21730    21730           
  Partials     1082     1082           
Impacted Files Coverage Δ
foqus_lib/framework/uq/SampleData.py 52.89% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review June 27, 2023 18:53
@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Jun 27, 2023
Copy link
Member

@sotorrio1 sotorrio1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@lbianchi-lbl lbianchi-lbl merged commit ceb1e46 into CCSI-Toolset:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures for Python 3.9 due to NumPy 1.25.0
2 participants