-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spell Checker #1168
Add Spell Checker #1168
Conversation
…ome known exceptions
@sotorrio1 the one remaining word flagged as an error is an instance of "ghostOuput" here:
That part seems to be related to PSUADE (i.e. writing the PSUADE input file), so I wanted to double-check if "ghostOuput" is a misspelling of "ghostOutput", or it's actually the correct string in the context of the PSUADE input file syntax. |
@lbianchi-lbl I'm pretty sure this is just a misspelling of "ghostOutput". It's only naming that variable "ghostOuput" in the case there are no outputs (all the variables are inputs). I've even tested the method generateSamples changing it to the correct spelling (ghostOutput) and it works fine. PSUADE is not looking for that specific (and wrong) string lol |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1168 +/- ##
==========================================
- Coverage 37.25% 37.10% -0.15%
==========================================
Files 160 160
Lines 36396 36396
Branches 5956 5956
==========================================
- Hits 13558 13504 -54
- Misses 21750 21794 +44
- Partials 1088 1098 +10 ☔ View full report in Codecov by Sentry. |
Summary/Motivation:
Adds spell checker to CI test runs.
Changes proposed in this PR:
Add CI setup necessary to run spell checker on PR runs
Initial configuration file with some known file type exceptions; comments lists all other (included) file types for reference
Open questions: 1) what file types should be included/excluded? 2) what known "misspellings" should be excepted, e.g. "IDAES"? 3) should we mandate that the
pylint
anddocs
checks wait on thespell-check
andcode-formatting
(black
), likepytest
does?Locally, navigating to the
FOQUS/
directory, installingtypos
and runningtypos --files
will list all files that are checked. Runningtypos --config ./.github/workflows/typos.toml
will run the spell check using the configuration file.Note: the Check Spelling test will fail for now, as we haven't actually corrected the spelling errors yet
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: