Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pandas deprecation #1214

Merged
merged 7 commits into from
May 7, 2024
Merged

Conversation

sotorrio1
Copy link
Member

@sotorrio1 sotorrio1 commented Mar 28, 2024

Fixes/Addresses:

Addresses issue #1212

Summary/Motivation:

Currently there is a future warning for a pandas deprecation affecting UQ, SDoE and ODoE when using the file results.py

Changes proposed in this PR:

  • cast data type for certain results df columns before assigning a value

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@sotorrio1 sotorrio1 added UQ Issues related to creating, filtering, and analyzing simulation ensembles SDoE Sequential Design of Experiments ODoE Robust Optimality-base Design of Experiments labels Mar 28, 2024
@sotorrio1 sotorrio1 self-assigned this Mar 28, 2024
@sotorrio1 sotorrio1 linked an issue Mar 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 38.77%. Comparing base (8da0631) to head (b4a7c67).
Report is 1 commits behind head on master.

❗ Current head b4a7c67 differs from pull request most recent head 402b5b1. Consider uploading reports for the commit 402b5b1 to get more accurate results

Files Patch % Lines
foqus_lib/framework/sampleResults/results.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
+ Coverage   38.54%   38.77%   +0.22%     
==========================================
  Files         164      164              
  Lines       37032    37044      +12     
  Branches     6132     6132              
==========================================
+ Hits        14274    14362      +88     
+ Misses      21619    21554      -65     
+ Partials     1139     1128      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl self-assigned this Apr 2, 2024
@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Apr 2, 2024
@sotorrio1 sotorrio1 changed the title Fixing pandas deprecation Draft: Fixing pandas deprecation Apr 16, 2024
@sotorrio1 sotorrio1 changed the title Draft: Fixing pandas deprecation Fixing pandas deprecation Apr 16, 2024
@sotorrio1 sotorrio1 marked this pull request as draft April 16, 2024 20:23
@sotorrio1 sotorrio1 marked this pull request as ready for review May 2, 2024 19:06
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie merged commit 7a04a6b into CCSI-Toolset:master May 7, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ODoE Robust Optimality-base Design of Experiments Priority:Normal Normal Priority Issue or PR SDoE Sequential Design of Experiments UQ Issues related to creating, filtering, and analyzing simulation ensembles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming pandas deprecation
3 participants