Updated Turbine configuration: FOQUS considers Aspen simulation successful even if there is error in Aspen #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n successful even if there is error in Aspen I updated turbineConfiguration.py, such that FOQUS will consider an Aspen Plus simulation to be successful, even though the Aspen Plus simulation reports to the user that the simulation completed with warnings and/or errors.
fsoepyan
added
enhancement
|
I don't think we want to do this. If the simulation ends in an error you want to know, and don't want FOQUS to say it was successful. At least this should be optional. This also doesn't fix the issue of results not being returned for outputs when there is an error, and warnings being mistaken for errors. Let's hold off on this until we track down the main source of the problem. |
fsoepyan
changed the title
|
|
Closing this as it was fixed by updating TurbineLite (https://github.com/CCSI-Toolset/turb_sci_gate/releases/tag/2.0.1). See issue #268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated turbineConfiguration.py, such that FOQUS will consider an Aspen Plus simulation to be successful, even though the Aspen Plus simulation reports to the user that the simulation completed with warnings and/or errors.