Fixes typo in CDMS raise statements #1240
Conversation
|
@remram44 I will check to see if the server is even up at all. Thanks. |
|
@remram44 could you please make a request against release? Master will need to move on. please refer to my email earlier. |
| else: | ||
| try: | ||
| datanode = loadURI(uri) | ||
| return datanode | ||
| except: | ||
| datanode = loadURI(uri) | ||
| raise "Error in loadURI of: ",uri | ||
| raise CDMSError, "Error in loadURI of: ",uri |
There was a problem hiding this comment.
well if we really want to make this python proper shouldn't this be:
raise CDMSError("Error in loadURI of %s" % uri)
There was a problem hiding this comment.
raise ExcType, argument is kind of an old way to write things, but is compatible with 2.x versions; I sticked with it since this is what is used throughout this file.
There was a problem hiding this comment.
I'd say let's make it clean so it will work when/if we move to Python 3.0. Since you brought that up, would you mind fixing it across the file? Thanks! Because the way it is now is also compatible with 2.x, so why bother changing it in the first place?
There was a problem hiding this comment.
I'm certain 2to3 handles that, but sure, I can fire a regex at it.
|
awesome! Thanks @remram44 |
Fixes typo in CDMS raise statements
See this ctest output