fix #1212 - Update spyder 2.3.3 to 2.3.4 #1300
Conversation
Update master
This should probably replace the other similar functions for consistency on the backend, but this works for now.
This change shouldn't affect external behavior at this point, but just organizes the code and separates the logic for different plot types to make the implementations more robust to changes and easier to read/follow/debug. The Pipeline class is an interface for interacting with VTK. At this point, it defines a single virtual method, plot(...), which takes arguments similar to VTKPlots.plot(...). It still returns the undocumented map with objects that are reused for animations, so that code should continue to function as before. This patch: - Creates initial Pipeline interface. - Add shared logic from Plot2D into Pipeline2D subclass. - Adds specific implementations as Boxfill-, Isoline-, Isofill-, and MeshfillPipeline subclasses. - Cleans up style to conform to PEP 8. - Reraise exception in new boxfill test when it makes sense (made it easier to track down why the test was failing.) - Creates vcs2vtk.isTrue(...) to perform consistent user_input-->bool conversions.
Vtk refactor
Sync master
|
@jbeezley @aashish24 is there something wrong with the buildbot/travis config? It would seem this PR doesn't do much and shouldn't have errored like it has.. The travis issue is with the osx build (as per usual), not sure what's happened with the buildbot |
|
These builds don't contain #1296 which just went into master. If you merge in the latest master and repushed, it will probably fix the problem. |
|
@jbeezley ok will do.. |
…thub.com:UV-CDAT/uvcdat into issue1212_durack1_Spyder2.3.4Update_uvcdatmaster
|
@doutriaux1 @aashish24 @jbeezley I'll just let this go and see if it returns any errors, then clean it up back to the original 1 file change in a new PR.. |
|
@jbeezley seems that same DODS problem is recurring https://open.cdash.org/testDetails.php?test=334469530&build=3804894 |
|
@jbeezley so DODS is still a problem, and the lines across the test image https://open.cdash.org/testDetails.php?test=334473135&build=3804928 |
|
@jbeezley as noted by @doutriaux1 it also seems that the netcdf version being picked up might be wrong https://open.cdash.org/testDetails.php?test=334479306&build=3804923 |
|
As for the lines across the test image, I have been unable to reproduce this on any of the platforms here at NASA. I looked over the code and it looks fine to me. So right now I really don’t know what would be causing this. — Tom From: "Paul J. Durack" <notifications@github.commailto:notifications@github.com> @jbeezleyhttps://github.com/jbeezley so DODS is still a problem, and the lines across the test image https://open.cdash.org/testDetails.php?test=334473135&build=3804928 — |
|
Yes, those failures are unrelated. Hopefully soon we will have all the tests passing on master. |
|
@durack1 I will have a look at this branch. Please don't merge until then. thanks, |
|
@aashish24 this branch needs some cleaning once it passes.. It'll be cleaner if I just close this and issue another PR once the tests are fixed.. I'll do this for my other PRs too |
|
@aashish24 should I clean up this PR and resubmit? Are the DODS and other issues above resolved? |
|
@doutriaux1 @aashish24 @jbeezley closing this PR and will re-issue a new PR once all the changes which have made their way into |
@doutriaux1 @aashish24 @jbeezley here's that pull request #1213 and #1299 issued against the uvcdat master branch - I'm hoping this triggers the buildbot testing.
If so (and it passes) I'll close the existing PRs #1213 and #1299