issue1579 durack1 update netcdf 4.3.3.1 to 4.4.0

[durack1]

Test update for netcdf-c 4.4.0-rc4

@aashish24 @doutriaux1 this is a placeholder - please do not merge until the final 4.4.0 release is out and this PR is updated

[aashish24]

@durack1 let's do it post 2.4

[durack1]

@aashish24 @doutriaux1 yep it's still in RC so 2.4+ is certainly where it should be merged..

[durack1]

This also needs a bump to the hdf libraries - so will update the sources and add that in

[durack1]

@doutriaux1 looks like the macbots are in trouble again..

[durack1]

@doutriaux1 I'd be inclined to update zlib from the confusing arrangement where there are 4 versions being built depending on the system, or using the system zlib, to a forced build of 1.2.8 the latest release

[aashish24]

@doutriaux1 @aashish24 it would be great to get this PR merged.. Can you folks take a look at it tomorrow

Yes, I will look into it tomorrow @durack1

[durack1]

@aashish24 @doutriaux1 ping!

[durack1]

@doutriaux1 @aashish24 can this please be reviewed pronto? It's been sitting in the queue for too long now

[durack1]

@doutriaux1 what's going on with the bots none of them are working any more

[durack1]

@dnadeau4 please test this PR and merge if it's all ok.
I'm uncertain why @aashish24 and @doutriaux1 have not reviewed and merged this already.

[dnadeau4]

All cdms2 test passed with netCDF 4.4.0 Somehow I cannot click "Merge Pull Request". @doutriaux1 did you change something in the "github" configuration?

[doutriaux1]

@durack1 pronto? Really? Are you our project manager now? We got many many fires going on right now and the last thing we need to need is add oil on the fire by merging something that has not been carefully reviewed. I apologize we could not get to this pronto. We'll try to work longer hours in the future...

[durack1]

@doutriaux1 if you can add it to the review queue that would be great. @dnadeau4 has also taken a look and tested in his env

[durack1]

@doutraux1 the garant failure is due to a missing baseline https://open.cdash.org/testDetails.php?test=425699817&build=4261331 - nothing to do with the PR

[durack1]

@doutriaux1 @aashish24 @dnadeau4 is there a reason that this is being held up? It seems like it's good to go..?

[doutriaux1]

yes there is, I do not have time to properly get to it, everytime I build it, something comes up and I forget and then I need to build it again the next time, etc...

[durack1]

@doutriaux1 ok great good to know.. I was wondering if there was something with the PR that needed attention.. If it's just time then good to know it's still in the queue..

[aashish24]

@durack1 @doutriaux1 if CI is happy, lets get this merged in.

[durack1]

@aashish24 I'll defer to @doutriaux1 for this

[doutriaux1]

@aashish24 I'm neither happy or not with it. I really need to look at it carefully first, sorry @durack1 I know you want it bad. Maybe Thursday I can take a close look at it.

[aashish24]

Maybe Thursday I can take a close look at it.

thanks @doutriaux1

[aashish24]

@durack1 talked to @doutriaux1 we will look into it past 2.4.1.