fix #18 tvariable missingvalue copy issue in subRegion (#21)

* fix #18 tvariable missingvalue copy issue in subRegion * space to trigger build
CDAT · Feb 21, 2017 · d6e3fe2 · d6e3fe2
1 parent f5cde4d
commit d6e3fe2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/Lib/tvariable.py b/Lib/tvariable.py
@@ -3,7 +3,7 @@
 
 """
 TransientVariable (created by createVariable)
-is a child of both AbstractVariable and the masked array class.
+is a  child of both AbstractVariable and the masked array class.
 Contains also the write part of the old cu interface.
 """
 import json
@@ -152,7 +152,7 @@ def __init__(self, data, typecode=None, copy=1, savespace=0,
  The savespace argument is ignored, for backward compatibility only.
  """
  try:
- if data.fill_value is not None:
+ if( (data.fill_value is not None) and (fill_value is None) ):
  self._setmissing(data.fill_value)
  fill_value = data.fill_value
  except:

diff --git a/Test/test_tvariable.py b/Test/test_tvariable.py
@@ -46,8 +46,7 @@ def testTV(self):
  self.assertEqual(missing_value, -99.9)
 
  tmv = tv.fill_value
- # TODO: Did the default value of fill_value/missing change? This is failing.
- #self.assertEqual(tmv, -99.9)
+ self.assertEqual(tmv, -99.9)
 
  grid = tv.getGrid()
  self.assertFalse(grid is None)