Issue78 strvar #89
Merged
Issue78 strvar #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dnadeau4 great! Does this PR provide read AND write for string variables, or just read? |
doutriaux1
reviewed
Feb 14, 2017
| @@ -58,9 +58,9 @@ | |||
| mpicc="mpicc" | |||
| subprocess.check_call([mpicc,"--version"]) | |||
| os.environ["CC"]=mpicc | |||
| os.environ["CFLAGS"]="-w -g" | |||
| os.environ["CFLAGS"]="-w -g -O0" | |||
There was a problem hiding this comment.
Since we have -g, -O0 helps for not optimizing some local variables, especially counter like i,j. Otherwise, they are optimized and we can't access their value. We should really get rid for -g -O0 when we distribute to make the program go faster.
|
@doutriaux1 merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now allow to read "NC_STRING" variables. test_allMIPs.py