-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convertaxis vector rebased scale 10x #334
Conversation
Doing this changes the direction of the vectors.
Fixes animation tests by making sure all mapper inputs are transformed at animation render time, using the per-actor transforms computing during the initial plotting.
This change fits the data to the viewport before using it to build the pipeline, rather than patching once the pipeline is built.
This is maybe the cause of every single test failing when running tests under python 3.
When one dimension of the plot is very small compared to the other, the fixed threshold of 1e-6 could sometimes result in markers being scaled so large they filled the entire plot.
These will result in a bunch of straight lines and don't make much sense given the test data.
And remove the cast (truncate) to int that was hidden in there as well.
9875f2b
to
5ef3752
Compare
5ef3752
to
550e7c6
Compare
I think this topic is ready for comparison against the original branch. This is the one where I left the default marker sizes as they were, but implemented the 10x scaling (changing the documentation to refer to screen size in "deci-pixels" rather than pixels). Now maybe we can pick one of these two different but related approaches and merge it 😉 |
hey guys.. can we speed up review and merge process to keep things interesting |
trust me i want to merge this! |
@aashish24 ok I merged this, I think it will be the least disruptive for users. |
thanks @doutriaux1 much appreciated 🎉 @scottwittenburg great work and help from @danlipsa and @doutriaux1 the results are looking very good. |
Here is the 10x scaling branch we talked about. The last four commits (from April 17, 2018) are the only difference between this branch and #331.
This goes with the baseline PR here:
CDAT/uvcdat-testdata#195