-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #397 needed to store continent value #398
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import basevcstest | ||
|
||
class TestVCSTextsExtents(basevcstest.VCSBaseTest): | ||
def testUpdateDoesNotTriggerContinents(self): | ||
s = self.clt["clt"][0] | ||
self.x.plot(s, continents=0) | ||
self.x.setcolormap("viridis") | ||
self.checkImage("test_vcs_update_triggers_continents.png") | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4054,6 +4054,8 @@ def __plot(self, arglist, keyargs): | |
dn.g_name = arglist[4] | ||
dn.array = arglist[:2] | ||
dn.backend = returned_kargs | ||
if "continents" in keyargs: | ||
dn._continents = keyargs["continents"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After browsing the source code, I'm not seeing how this value stored on the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you're right, it's sort of obscure but i think it's there: https://github.com/CDAT/vcs/blob/master/vcs/VTKPlots.py#L491 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, you referred to it with an underscore in your fix, so I was searching for it that way, forgetting about how you typically make "properties" out of those attributes. Thanks. |
||
else: | ||
dn = None | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I guess while I knew you could disable the continents somehow, I never knew this is how you did it.