Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we call the infection seeding process "seeding"? #206

Closed
dylanhmorris opened this issue Jun 20, 2024 · 5 comments · Fixed by #261
Closed

Should we call the infection seeding process "seeding"? #206

dylanhmorris opened this issue Jun 20, 2024 · 5 comments · Fixed by #261
Assignees

Comments

@dylanhmorris
Copy link
Collaborator

dylanhmorris commented Jun 20, 2024

Minor: Do you think the risk is low that someone misconstrues seed here for reproducibility / something involved in numpyro.sample() vs. interpreting post_seed_latent_infections as the infections after seeded infections $I_{v:0}$ have been incorporated?

I think the risk is low, given that those who might be interested in using this enough to peruse the source code would understand this.

Originally posted by @AFg6K7h4fhy2 in #204 (comment)

@AFg6K7h4fhy2
Copy link
Collaborator

Bumping this. Any thoughts here @damonbayer @dylanhmorris?

@damonbayer
Copy link
Collaborator

I like it as is, but, if I had to suggest something, it would be to replace "seeding" with "initialization." The main problem with that is ambiguity around "initial infections" which (to me) suggests a single time point, while "seed infections" (to me) could suggest multiple time points.

@dylanhmorris
Copy link
Collaborator Author

dylanhmorris commented Jul 9, 2024

post_initialization_latent_infections seems pretty clear to me.

If we ever have ambiguity, initial_infections_vector or initial_infections_timeseries can clarify that it's not necessarily a single timepoint.

@seabbs
Copy link
Collaborator

seabbs commented Jul 9, 2024

In hhh4 this is called the endemic-epidemic framework (so seeding is endemic). In epiestim it would be called importation I think

@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the N Sprint milestone Jul 10, 2024
@AFg6K7h4fhy2
Copy link
Collaborator

In conferring with @damonbayer and @dylanhmorris, we decided that a seemingly good naming convention that MSR can adopt for "infections seeding process" is post_initialization_latent_infections. As such, I will ensure this convention is correctly adopted in the code.

@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Jul 11, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 linked a pull request Jul 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants