Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validation() methods optional and class specific #288

Open
dylanhmorris opened this issue Jul 22, 2024 · 3 comments
Open

Make validation() methods optional and class specific #288

dylanhmorris opened this issue Jul 22, 2024 · 3 comments
Assignees
Labels
clean up Good code that could be better discussion

Comments

@dylanhmorris
Copy link
Collaborator

Right now, validate() is a mandatory method for subclasses of RandomVariable, but many actual random variables do not have meaningful validation implemented.

We should decide whether most/all can and should have to have meaningful validation. If so, we should implement. If not, perhaps the base class method be a concrete pass that gets overridden / extended by subclass validation methods.

See #275 (comment)_

@dylanhmorris
Copy link
Collaborator Author

We should make a decision on this and move forward. Leaning toward removing validate as a mandatory method, and letting individual RVs define validation or not as appropriate. @damonbayer @sbidari thoughts?

@damonbayer
Copy link
Collaborator

Agree with making this optional.

@sbidari
Copy link
Collaborator

sbidari commented Sep 13, 2024

Agree!

@dylanhmorris dylanhmorris changed the title Add input validation for all RandomVariables or make validation() methods optional Make validation() methods optional and class specific Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Good code that could be better discussion
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants