You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, validate() is a mandatory method for subclasses of RandomVariable, but many actual random variables do not have meaningful validation implemented.
We should decide whether most/all can and should have to have meaningful validation. If so, we should implement. If not, perhaps the base class method be a concrete pass that gets overridden / extended by subclass validation methods.
We should make a decision on this and move forward. Leaning toward removing validate as a mandatory method, and letting individual RVs define validation or not as appropriate. @damonbayer@sbidari thoughts?
dylanhmorris
changed the title
Add input validation for all RandomVariables or make validation() methods optional
Make validation() methods optional and class specific
Sep 13, 2024
Right now,
validate()
is a mandatory method for subclasses ofRandomVariable
, but many actual random variables do not have meaningful validation implemented.We should decide whether most/all can and should have to have meaningful validation. If so, we should implement. If not, perhaps the base class method be a concrete
pass
that gets overridden / extended by subclass validation methods.See #275 (comment)_
The text was updated successfully, but these errors were encountered: