Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a CensoredNormal distribution #427

Closed
sbidari opened this issue Sep 4, 2024 · 1 comment · Fixed by #428
Closed

Create a CensoredNormal distribution #427

sbidari opened this issue Sep 4, 2024 · 1 comment · Fixed by #428
Labels
pyrenew related to pyrenew internals

Comments

@sbidari
Copy link
Collaborator

sbidari commented Sep 4, 2024

The observation process for the log viral genome concentration in wastewater follow a censored normal distribution with concentration below the level of detection (LOD) censored.
We can use @dylanhmorris's implementation of the censored normal distribution here.

I am wondering if the censored normal distribution in PyRenew should inherit from the RandomVariable class instead of numpyro.distributions.Distribution so that it can be "time-aware" like all other randomvariables. Thoughts? @damonbayer @dylanhmorris @AFg6K7h4fhy2

@dylanhmorris
Copy link
Collaborator

I would advocate for a full distribution and then using DistributionalVariable when we want to treat it as an RV

@sbidari sbidari linked a pull request Sep 4, 2024 that will close this issue
@sbidari sbidari added this to the R Sprint milestone Sep 4, 2024
@damonbayer damonbayer added the pyrenew related to pyrenew internals label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pyrenew related to pyrenew internals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants