-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor convolve scanner factory functions #161
Refactor convolve scanner factory functions #161
Conversation
…ake-identity-transforms-default-for-new_double_scanner
…sformation in infection_functions.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 94.77% 94.78%
=======================================
Files 39 39
Lines 842 843 +1
=======================================
+ Hits 798 799 +1
Misses 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check the size/shape/type of inputs?
@damonbayer are you talking about checking the inputs to the factories or about having the functions they produce/return perform input checks? |
Checking inputs to factories so we can provide useful errors. |
Things that occur to me:
Stricter stuff that I'm more reluctant to implement:
Anything else you had in mind @damonbayer? |
@dylanhmorris Sounds good to me. |
…lidation helper function and test for it
…ake-identity-transforms-default-for-new_double_scanner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Test pass and the website is rendered correctly.
Ready for review.
This PR:
new_double_scanner
tonew_double_convolve_scanner
for consistency.new_convolve_scanner
, make identity transforms default fornew_double_scanner
#147 by adding transform functionality tonew_convolve_scanner
Out of scope
logistic_susceptibility_adjustment
)new_convolve_scanner
andnew_double_scanner
function factories withConvolveScanner
classes? #177