Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid None encountered in jnp array warning #270

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Jul 16, 2024

Add condition for padding observed_infection in rtinfectionsrenewalmodel.py to avoid padding the observed_infection when the infection_obs_process_rv is None and prevent the None encountered warning.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (fb8a8a4) to head (31d2121).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          40       40           
  Lines         908      909    +1     
=======================================
+ Hits          842      843    +1     
  Misses         66       66           
Flag Coverage Δ
unittests 92.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out @sbidari! I think we can remove the the plot.show() lines you added, though.

@sbidari
Copy link
Collaborator Author

sbidari commented Jul 16, 2024

I think we either need plot.show() or a semi-colon on the end of the code on the cells with plots. Quarto didn't like it when there were multiple outputs from a single code cell (at least while rendering the docs locally on my computer)

edit: I realize that the addition of plot.show() is totally unrelated to the issue in this PR and probably would have been better as it's own PR. I noticed the images were not rendering properly while I was working on this and fixed it.

@damonbayer
Copy link
Collaborator

edit: I realize that the addition of plot.show() is totally unrelated to the issue in this PR and probably would have been better as it's own PR. I noticed the images were not rendering properly while I was working on this and fixed it.

Interesting. Please create new issue and/or PR to describe and fix this problem.

@damonbayer damonbayer self-requested a review July 16, 2024 23:16
@damonbayer damonbayer merged commit a622187 into main Jul 16, 2024
8 checks passed
@damonbayer damonbayer deleted the 255-investigate-warning-about-none-encountered-in-jnparray-in-tutorials branch July 16, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate warning about None encountered in jnp.array() in tutorials
2 participants