Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Model.run so parameters always get passed #279

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

dylanhmorris
Copy link
Collaborator

Previously, parameters passed would get ignored on calls to run() after the first, since run did not re-create the MCMC and NUTS objects. Since this creation operation is not expensive, I think they should just be re-created at each run() call

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (a2bd8e4) to head (b9c0769).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   92.80%   92.79%   -0.01%     
==========================================
  Files          40       40              
  Lines         903      902       -1     
==========================================
- Hits          838      837       -1     
  Misses         65       65              
Flag Coverage Δ
unittests 92.79% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dylanhmorris dylanhmorris merged commit 54d3ccb into main Jul 18, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the dylanhmorris-always-init-model branch July 18, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants