Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MyRt in hospital_admissions_model.qmd more flexible #293

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

damonbayer
Copy link
Collaborator

@damonbayer damonbayer commented Jul 22, 2024

Could be merged in response to my comment here: #275 (comment). I implemented this for another PR, but ended up not using it. This could also be closed without merging.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (accaaaf) to head (a44175f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          39       39           
  Lines         903      903           
=======================================
  Hits          838      838           
  Misses         65       65           
Flag Coverage Δ
unittests 92.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer damonbayer changed the title Investigate issue with MCMC using Transformed Overdispersion parameter Make MyRt in hospital_admissions_model.qmd more flexible Jul 23, 2024
@damonbayer damonbayer marked this pull request as ready for review July 23, 2024 15:45
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I think it's worth merging

@dylanhmorris dylanhmorris merged commit 9607ea8 into main Jul 23, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the dmb_genericize_my_rt branch July 23, 2024 16:19
@damonbayer damonbayer added this to the 🦆 Olorotitan milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants