Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create and use default rt across tests #372

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Aug 13, 2024

closes #287

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (bf09a37) to head (e37562f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          39       39           
  Lines         909      909           
=======================================
  Hits          847      847           
  Misses         62       62           
Flag Coverage Δ
unittests 93.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari sbidari marked this pull request as ready for review August 13, 2024 15:03
model/src/test/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be really nice. Two suggestions.

@damonbayer damonbayer self-requested a review August 13, 2024 17:53
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbidari!

@damonbayer damonbayer merged commit 0fc0c8d into main Aug 13, 2024
7 checks passed
@damonbayer damonbayer deleted the increase_DRY_across_tests branch August 13, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-use simple Rt definition throughout testing suite
2 participants