Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the post-page-artifact job #456

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Adding the post-page-artifact job #456

merged 5 commits into from
Oct 24, 2024

Conversation

gvegayon
Copy link
Member

Using the gh cli interface, this update to the pkgdown workflow posts a comment to the PR linking to the pages artifact for easy download.

@gvegayon gvegayon linked an issue Sep 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (a1466ae) to head (cb6208c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files          41       41           
  Lines         949      949           
=======================================
  Hits          916      916           
  Misses         33       33           
Flag Coverage Δ
unittests 96.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Thank you for your contribution @gvegayon🚀! Your page is ready to preview 👉 here 👈!

@damonbayer
Copy link
Collaborator

Will this update when there are new commits to the PR?

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest either adding comment updating (versus reposting) before merging or alternatively waiting for the cfa-actions repo and just pointing to that. Defer to @damonbayer on which.

@damonbayer
Copy link
Collaborator

Let’s wait for the CFA actions repo. Will be thrilled to add that when it is available, but closing for now.

@damonbayer damonbayer closed this Sep 25, 2024
@gvegayon gvegayon reopened this Oct 23, 2024
Copy link

Thank you for your contribution @gvegayon🚀! Your page is ready to preview 👉 here 👈!

Copy link

github-actions bot commented Oct 23, 2024

Thank you for your contribution @gvegayon 🚀! Your github-pages is ready for download 👉 here 👈!
(The artifact expires on 2024-10-30T22:14:05Z. You can re-generate it by re-running the workflow here.)

@gvegayon
Copy link
Member Author

@damonbayer, I just re-opened this using the new CDC/cfa-actions/post-artifact action.

@damonbayer
Copy link
Collaborator

@gvegayon is it working as you expect? I'm a bit confused by the two comments from the bot.

@dylanhmorris
Copy link
Collaborator

Is the first comment just from the reopening of the issue?

@dylanhmorris
Copy link
Collaborator

dylanhmorris commented Oct 23, 2024

I note that the second auto comment (which reflects the new action) was posted and then edited twice, which lines up with @gvegayon's three commits since reopening (the first of which switched to the new action)

@gvegayon
Copy link
Member Author

Yupi!!

@gvegayon gvegayon merged commit a63c4ea into main Oct 24, 2024
8 checks passed
@gvegayon gvegayon deleted the pages-preview branch October 24, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview github-pages on PRs
3 participants