Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoints to update person cluster on patient #101

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Oct 28, 2024

Description

Adding two new endpoints to support updating the Person cluster a Patient belongs to. One is for assigning the Patient to a specific cluster, and another is for assigning them to a new cluster.

Related Issues

closes #96

Additional Notes

  • POST /patient/<ref-id>/person takes an empty payload, creates a new Person cluster, assigns the Patient to that cluster and returns back reference ids for both the Patient and Person.
  • PATCH /patient/<ref-id>/person takes a person ref id payload, assigned the Patient to that existing Person and returns back reference ids for both the Patient and Person.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.89%. Comparing base (2533adb) to head (de22217).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   94.58%   94.89%   +0.30%     
==========================================
  Files          21       23       +2     
  Lines        1146     1195      +49     
==========================================
+ Hits         1084     1134      +50     
+ Misses         62       61       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review October 28, 2024 15:59
Copy link
Contributor

@alhayward alhayward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left 2 questions.

@ericbuckley ericbuckley merged commit e89fdda into main Oct 29, 2024
10 checks passed
@ericbuckley ericbuckley deleted the feature/96-update-patient branch October 29, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoints to update Patient cluster
3 participants