generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
endpoints to update person cluster on patient #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 94.58% 94.89% +0.30%
==========================================
Files 21 23 +2
Lines 1146 1195 +49
==========================================
+ Hits 1084 1134 +50
+ Misses 62 61 -1 ☔ View full report in Codecov by Sentry. |
cbrinson-rise8
approved these changes
Oct 29, 2024
alhayward
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left 2 questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding two new endpoints to support updating the Person cluster a Patient belongs to. One is for assigning the Patient to a specific cluster, and another is for assigning them to a new cluster.
Related Issues
closes #96
Additional Notes
POST /patient/<ref-id>/person
takes an empty payload, creates a new Person cluster, assigns the Patient to that cluster and returns back reference ids for both the Patient and Person.PATCH /patient/<ref-id>/person
takes a person ref id payload, assigned the Patient to that existing Person and returns back reference ids for both the Patient and Person.<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: