Incorporate classnames package and do some general cleanup #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does the following:
classNames
where appropriateprettier
andeslint
devDependencies
were added for thisprettier
defaultsFooter
component renders afooter
element rather than anotherheader
NavigationLink
and its prop type into its own filebasePath
variable into its ownconstants.ts
filefavicon.ico
Testing
npm i
to install the new packagesIf you happen to run into any issues, it might be worth trying to delete the
.next
folder and restarting your dev build.Discussion
The "reasonable defaults" felt like a good starting point to me but we can definitely adjust these over time if we think any of the ESLint rules aren't useful to us.