Basic carousel for new site #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakewheeler
requested changes
Oct 29, 2024
src/app/components/Carousel.tsx
Outdated
| setFinalOffset(finalOffset + dragOffset); // Keep track of cumulative offset | ||
| setIsDragging(false); | ||
| setDragOffset(0); // Reset drag offset after drag ends | ||
| // setFinalOffset(0); |
There was a problem hiding this comment.
Should we delete this line? Was this just for testing?
src/app/globals.css
Outdated
| } | ||
|
|
||
| .carousel-item { | ||
| min-width: calc(100% / 7); /* Adjust based on number of visible items */ |
There was a problem hiding this comment.
Is this number intended to match itemsPerView?
jakewheeler
reviewed
Nov 6, 2024
Comment on lines
1
to
11
| .sliderContainer { | ||
| h3 { | ||
| font-size: 36px; | ||
| margin: 10px; | ||
| padding: 2% 0; | ||
| background: var(--ifm-color-primary); | ||
| color: #fff; | ||
| line-height: 100px; | ||
| text-align: center; | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we still need these styles? Looks like maybe not.
jakewheeler
reviewed
Nov 6, 2024
src/app/page.tsx
Outdated
| used DIBBs to solve their toughest data challenges | ||
| </p> | ||
| <> | ||
| <ContentContainer align classes="px-14 pt-20 pb-10"> |
There was a problem hiding this comment.
Please double check that your styling still works here once you merge #41 in 😃
jakewheeler
reviewed
Nov 6, 2024
src/app/layout.tsx
Outdated
Comment on lines
6
to
7
| import 'slick-carousel/slick/slick.css'; | ||
| import 'slick-carousel/slick/slick-theme.css'; |
There was a problem hiding this comment.
We could move these two imports into Carousel.tsx?
jakewheeler
reviewed
Nov 6, 2024
jakewheeler
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic carousel for the bottom of the homepage.
Also adds buttons for tabbing and keyboard control.
