Create eCR case study page #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakewheeler
commented
Nov 26, 2024
| @@ -0,0 +1,75 @@ | |||
| import Link from 'next/link'; | |||
There was a problem hiding this comment.
The Next docs recommend using private folders to share code like this between pages.
jakewheeler
commented
Nov 26, 2024
| @@ -29,7 +29,7 @@ export default function CaseStudies() { | |||
| data pipeline that automatically processes and enriches eCR data | |||
| to improve downstream data analysis and case investigation. | |||
| </Text> | |||
| <LinkButton variant="primary" href="/case-studies/la-county"> | |||
| <LinkButton variant="primary" href="/case-studies/dibbs-pipeline"> | |||
There was a problem hiding this comment.
The desired URLs have been added to Figma, so I've gone ahead and updated them.
nickbristow
reviewed
Nov 27, 2024
src/app/case-studies/_ui/index.tsx
Outdated
| children: React.ReactNode; | ||
| } | ||
|
|
||
| function PageContainer({ children }: ContainerProps) { |
There was a problem hiding this comment.
Any reason not to use arrow functions?
nickbristow
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a couple of case study related changes:
/case-studies/ecr-viewer