Skip to content

Commit

Permalink
remove dibbs container (#2888)
Browse files Browse the repository at this point in the history
* add dibbs directly into ingestion

* add dibbs directly into message-parser

* add dibbs directly into message-refiner

* add dibbs directly into orchestration

* add dibbs directly into record linkage

* add dibbs directly into trigger-code-reference

* add dibbs directly into validation

* remove containers/dibbs

* update github workflows

* update base_service.py

* update tests to use pyproject.toml as source of truth

* add toml as dev requirement

* update pyproject path

* remove first character from version

* remove duplicate deps

* remove dupe reqs

* fix snyk

* fix requirements pin
  • Loading branch information
BobanL authored Nov 13, 2024
1 parent c358b20 commit e122080
Show file tree
Hide file tree
Showing 54 changed files with 882 additions and 278 deletions.
3 changes: 0 additions & 3 deletions .github/codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ coverage:
flags:
- sdk
flags:
dibbs:
paths:
- "containers/dibbs"
ecr-viewer:
paths:
- "containers/ecr-viewer"
Expand Down
83 changes: 0 additions & 83 deletions .github/workflows/container-dibbs.yaml

This file was deleted.

1 change: 0 additions & 1 deletion .github/workflows/container-ingestion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
- "**"
paths:
- containers/ingestion/**
- containers/dibbs/**
- containers/fhir-converter/**
merge_group:
types:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/container-message-parser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
- "**"
paths:
- containers/message-parser/**
- containers/dibbs/**
- containers/fhir-converter/**
merge_group:
types:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/container-message-refiner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
- "**"
paths:
- containers/message-refiner/**
- containers/dibbs/**
- containers/fhir-converter/**
merge_group:
types:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/container-record-linkage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
- "**"
paths:
- containers/record-linkage/**
- containers/dibbs/**
merge_group:
types:
- checks_requested
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/container-trigger-code-reference.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
- "**"
paths:
- containers/trigger-code-reference/**
- containers/dibbs/**
merge_group:
types:
- checks_requested
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/container-validation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
- "**"
paths:
- containers/validation/**
- containers/dibbs/**
- containers/fhir-converter/**
merge_group:
types:
Expand Down
9 changes: 0 additions & 9 deletions containers/dibbs/Dockerfile

This file was deleted.

3 changes: 0 additions & 3 deletions containers/dibbs/README.md

This file was deleted.

2 changes: 0 additions & 2 deletions containers/dibbs/dev-requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion containers/dibbs/dibbs/__init__.py

This file was deleted.

51 changes: 0 additions & 51 deletions containers/dibbs/dibbs/utils.py

This file was deleted.

9 changes: 0 additions & 9 deletions containers/dibbs/pyproject.toml

This file was deleted.

4 changes: 0 additions & 4 deletions containers/dibbs/requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion containers/dibbs/tests/assets/test_description.md

This file was deleted.

61 changes: 0 additions & 61 deletions containers/dibbs/tests/test_base_service.py

This file was deleted.

1 change: 1 addition & 0 deletions containers/ecr-viewer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"lint": "next lint",
"test": "TZ=America/New_York jest",
"test:watch": "TZ=America/New_York jest --watch",
"clear-local": "docker compose -f ./docker-compose.yml --profile \"*\" down -v",
"convert-seed-data": "npx @dotenvx/dotenvx run -f .env.local -- sh -c 'docker compose -f ./docker-compose.yml --profile ${SOURCE} --profile ${METADATA_DATABASE_TYPE} --profile ecr-viewer up -d && docker compose -f ./seed-scripts/docker-compose-seed.yml up --abort-on-container-exit && docker compose -f ./docker-compose.yml --profile \"*\" down && docker compose -f ./seed-scripts/docker-compose-seed.yml --profile \"*\" down'",
"convert-seed-data:build": "npx @dotenvx/dotenvx run -f .env.local -- sh -c 'docker compose -f ./docker-compose.yml --profile ${SOURCE} --profile ${METADATA_DATABASE_TYPE} --profile ecr-viewer up -d --build && docker compose -f ./seed-scripts/docker-compose-seed.yml up --abort-on-container-exit --build && docker compose -f ./docker-compose.yml --profile \"*\" down && docker compose -f ./seed-scripts/docker-compose-seed.yml --profile \"*\" down'",
"update-cypress-data": "docker compose -f ./seed-scripts/docker-compose-create-sql.yml up --build --abort-on-container-exit",
Expand Down
7 changes: 6 additions & 1 deletion containers/ingestion/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
FROM ghcr.io/cdcgov/phdi/dibbs
FROM python:3.11-slim

RUN apt-get update && \
apt-get upgrade -y

RUN pip install --upgrade pip

WORKDIR /code

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from importlib import metadata
from pathlib import Path
from typing import Literal

Expand Down Expand Up @@ -69,7 +68,7 @@ def __init__(
self.include_health_check_endpoint = include_health_check_endpoint
self.app = FastAPI(
title=service_name,
version=metadata.version("dibbs"),
version="1.7.1",
contact=DIBBS_CONTACT,
license_info=LICENSES[license_info],
description=description,
Expand Down
3 changes: 1 addition & 2 deletions containers/ingestion/app/main.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from pathlib import Path

from dibbs.base_service import BaseService

from app.base_service import BaseService
from app.config import get_settings
from app.routers import cloud_storage
from app.routers import fhir_geospatial
Expand Down
3 changes: 2 additions & 1 deletion containers/ingestion/dev-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
pytest
rich
testcontainers[compose]==3.7.1
testcontainers[compose]==3.7.1
toml
4 changes: 3 additions & 1 deletion containers/ingestion/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
../dibbs
pydantic==1.10.13
fastapi>=0.109.1
uvicorn
azure-identity
azure-keyvault-secrets
azure-storage-blob
Expand Down
14 changes: 9 additions & 5 deletions containers/ingestion/tests/test_base_service.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from importlib import metadata
from pathlib import Path

from dibbs.base_service import BaseService
from dibbs.base_service import DIBBS_CONTACT
from dibbs.base_service import LICENSES
import toml
from app.base_service import BaseService
from app.base_service import DIBBS_CONTACT
from app.base_service import LICENSES
from fastapi.testclient import TestClient

default_app_version = metadata.version("dibbs")
with open(
Path(__file__).parent.parent.parent.parent / "pyproject.toml"
) as project_config_file:
project_config = toml.load(project_config_file)
default_app_version = project_config["tool"]["poetry"]["version"][1:]


def test_base_service():
Expand Down
7 changes: 6 additions & 1 deletion containers/message-parser/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
FROM ghcr.io/cdcgov/phdi/dibbs
FROM python:3.11-slim

RUN apt-get update && \
apt-get upgrade -y

RUN pip install --upgrade pip

WORKDIR /code

Expand Down
Loading

0 comments on commit e122080

Please sign in to comment.