Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fax to contact points #2863

Merged
merged 18 commits into from
Nov 7, 2024
Merged

Add fax to contact points #2863

merged 18 commits into from
Nov 7, 2024

Conversation

mcmcgrath13
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 commented Nov 5, 2024 •
edited
Loading

PULL REQUEST

Summary

Make sure the fax number is converted along with other telecom info. Depends on skylight-hq/FHIR-Converter#4

  • add to snapshot test for converter service
  • expect fax system usage in formatContactPoint
  • add unit test

Related Issue

Fixes #2695

Additional Information

Before:
image

With this change:
image

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@mcmcgrath13 mcmcgrath13 changed the title test: make sure fax gets converted Add fax to contact points Nov 5, 2024
Base automatically changed from mcm/move-custom-fhir to main November 7, 2024 13:27
@mcmcgrath13 mcmcgrath13 marked this pull request as ready for review November 7, 2024 15:49
@mcmcgrath13 mcmcgrath13 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 7d7d27e Nov 7, 2024
31 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm/fix-telecom-fax branch November 7, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@angelathe angelathe Awaiting requested review from angelathe

@austin-hall-skylight austin-hall-skylight Awaiting requested review from austin-hall-skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmcgrath13 @BobanL