Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render lab result HTML as is if it does not conform to the expected format #2897

Merged
merged 25 commits into from
Nov 22, 2024

Conversation

austin-hall-skylight
Copy link
Collaborator

@austin-hall-skylight austin-hall-skylight commented Nov 13, 2024

PULL REQUEST

Summary

If a lab result does not have the "Observation entry reference value" extension in the Observation resource, display the lab results table from the "div" property of the "Results" section in the Composition resource.

Related Issue

Fixes #2830

Acceptance Criteria

  • Ecr's containing lab results with the "Observation entry reference value" extension such with the as this one display the labs in the eCR Summary and Lab Info sections the same way that we have been displaying them.
  • Ecr's containing lab results without the "Observation entry reference value" extension such with the as this one display the lab results from the "div" property of the "Results" section in the Composition resource in the eCR Summary and Lab Info sections.

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

mappings: PathMappings,
labReportJson: TableJson,
) {
const labTableDiagnostic = evaluateDiagnosticReportData(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a much bigger comment than this PR, but I've been contemplating why it was so hard to track down that key warning and I think part of the complexity might be that we aren't using components enough. We have a lot of regular functions that return JSX and maybe we'd be better off turning those into proper components and leaning more into React

Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor!

@austin-hall-skylight austin-hall-skylight added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 8691ed2 Nov 22, 2024
15 checks passed
@austin-hall-skylight austin-hall-skylight deleted the austin/render-table-spike branch November 22, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPIKE: display HTML tables for lab results
2 participants