-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render lab result HTML as is if it does not conform to the expected format #2897
Conversation
…view for ecr summary
mappings: PathMappings, | ||
labReportJson: TableJson, | ||
) { | ||
const labTableDiagnostic = evaluateDiagnosticReportData( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a much bigger comment than this PR, but I've been contemplating why it was so hard to track down that key
warning and I think part of the complexity might be that we aren't using components enough. We have a lot of regular functions that return JSX and maybe we'd be better off turning those into proper components and leaning more into React
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice refactor!
PULL REQUEST
Summary
If a lab result does not have the "Observation entry reference value" extension in the Observation resource, display the lab results table from the "div" property of the "Results" section in the Composition resource.
Related Issue
Fixes #2830
Acceptance Criteria
Additional Information
Anything else the review team should know?
Checklist