Fix ordering of notes/comments #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmcgrath13
commented
Nov 14, 2024
containers/fhir-converter/Dockerfile
Outdated
| @@ -1,7 +1,7 @@ | |||
| FROM mcr.microsoft.com/dotnet/sdk:6.0 AS build | |||
|
|
|||
| # Download FHIR-Converter | |||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch v7.0-skylight-7 --single-branch /build/FHIR-Converter | |||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch mcm/fix-note-order --single-branch /build/FHIR-Converter | |||
There was a problem hiding this comment.
TODO: update to released tag before merge
mcmcgrath13
commented
Nov 14, 2024
| plannedProcedures: "Bundle.entry.resource.where(resourceType = 'CarePlan').activity" | ||
| plannedProcedureName: "detail.code.coding[0].display" | ||
| plannedProcedureOrderedDate: "extension.where(url = 'dibbs.orderedDate').valueString" | ||
| plannedProcedureScheduledDate: "detail.scheduledString" | ||
|
|
||
| # Administered Medications | ||
| administeredMedications: "Bundle.entry.resource.section.where(code.coding[0].code = '29549-3').text" |
There was a problem hiding this comment.
this wasn't used anywhere
mcmcgrath13
requested review from
BobanL,
angelathe and
austin-hall-skylight
BobanL
approved these changes
Nov 15, 2024
mcmcgrath13
commented
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Incorporate changes from skylight-hq/FHIR-Converter#10. Always use the original text and not a parsed/reconstructed version.
Also added a little clean up to move the getting of the
divinto phirpath and out of JS to keep logic more consolidated.Related Issue
Fixes #2669
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
Additional Information
Anything else the review team should know?
Checklist