update evaluate cache to use a smaller key #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobanL
requested review from
lina-roth,
mcmcgrath13,
angelathe,
JNygaard-Skylight and
austin-hall-skylight
mcmcgrath13
reviewed
Nov 20, 2024
mcmcgrath13
reviewed
Nov 20, 2024
mcmcgrath13
reviewed
Nov 20, 2024
Co-authored-by: Mary McGrath <m.c.mcgrath13@gmail.com>
BobanL
commented
Nov 21, 2024
containers/fhir-converter/Dockerfile
Outdated
| @@ -1,7 +1,7 @@ | |||
| FROM mcr.microsoft.com/dotnet/sdk:6.0 AS build | |||
|
|
|||
| # Download FHIR-Converter | |||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch v7.0-skylight-11 --single-branch /build/FHIR-Converter | |||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch boban/add-id-to-bundle --single-branch /build/FHIR-Converter | |||
There was a problem hiding this comment.
todo - update this to latest
mcmcgrath13
reviewed
Nov 21, 2024
mcmcgrath13
reviewed
Nov 21, 2024
mcmcgrath13
reviewed
Nov 21, 2024
mcmcgrath13
reviewed
Nov 25, 2024
| @@ -52,7 +52,7 @@ describe("Snapshot test for Procedures (Treatment Details)", () => { | |||
| performedDateTime: "06/24/2022", | |||
| }, | |||
| { | |||
| id: "b40f0081-4052-4971-3f3b-e3d9f5e1e44d", | |||
| id: "b40f0081-4052-4971-3f3b-e3d9f5e1e44e", | |||
There was a problem hiding this comment.
why change the id here?
There was a problem hiding this comment.
because this ID was duplicated in this example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Related Issue
Fixes #2679
Additional Information
Anything else the review team should know?