Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix information expsure through error message #2993

Merged
merged 5 commits into from
Dec 9, 2024
Merged

fix information expsure through error message #2993

merged 5 commits into from
Dec 9, 2024

Conversation

gordonfarrell
Copy link
Collaborator

PULL REQUEST

Summary

Updating some error messages and logging in the refiner to fix a security issue

Related Issue

Fixes #2974

Acceptance Criteria

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@gordonfarrell gordonfarrell marked this pull request as draft December 6, 2024 16:02
@gordonfarrell gordonfarrell marked this pull request as ready for review December 9, 2024 17:26
BobanL
BobanL approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵

@gordonfarrell gordonfarrell added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 4773df9 Dec 9, 2024
13 checks passed
@gordonfarrell gordonfarrell deleted the gordon/information-exposure branch December 9, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@lina-roth lina-roth Awaiting requested review from lina-roth lina-roth is a code owner

@angelathe angelathe Awaiting requested review from angelathe angelathe is a code owner

@JNygaard-Skylight JNygaard-Skylight Awaiting requested review from JNygaard-Skylight JNygaard-Skylight is a code owner

@austin-hall-skylight austin-hall-skylight Awaiting requested review from austin-hall-skylight austin-hall-skylight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Information exposure through an exception
2 participants
@gordonfarrell @BobanL