Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltips per spec #2998

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Update tooltips per spec #2998

merged 9 commits into from
Dec 9, 2024

Conversation

mcmcgrath13
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 commented Dec 6, 2024 •
edited
Loading

PULL REQUEST

Summary

Ensure tooltips match those from the tooltip sheet.

In doing this I noticed a couple things that I also fixed:

  1. Use children instead of content for our ToolTipElement as it is more idiomatic
  2. The jurisdictions tooltip was sometimes not displaying as it was too big for the screen. I made the CSS more dynamic so that on smaller screens, the tooltip won't get cut off and not display at all (plus a weird pointer flickering that was happening in this case)

Related Issue

Fixes #

Acceptance Criteria

  • 4 new tooltips are added for:
    • Facility Details
    • Provider Details
    • eRSD Warnings
    • eICR Custodian Details
  • Tooltip for Sender Software is removed (since that field no longer exists and the new field names are more clear)
  • Tooltip copy matches the tooltip content in this sheet

Additional Information

image image image image

@mcmcgrath13 mcmcgrath13 changed the title Mcm/tooltip updates Update tooltips per spec Dec 6, 2024
@mcmcgrath13 mcmcgrath13 marked this pull request as ready for review December 6, 2024 16:26
BobanL
BobanL approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧰

@mcmcgrath13 mcmcgrath13 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 8f929f8 Dec 9, 2024
15 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm/tooltip-updates branch December 9, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@austin-hall-skylight austin-hall-skylight Awaiting requested review from austin-hall-skylight austin-hall-skylight is a code owner

@angelathe angelathe Awaiting requested review from angelathe angelathe is a code owner

@lina-roth lina-roth Awaiting requested review from lina-roth lina-roth is a code owner

@gordonfarrell gordonfarrell Awaiting requested review from gordonfarrell gordonfarrell is a code owner

@JNygaard-Skylight JNygaard-Skylight Awaiting requested review from JNygaard-Skylight JNygaard-Skylight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmcgrath13 @BobanL