fix ID and aria control string issue #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonfarrell
requested review from
BobanL,
lina-roth,
mcmcgrath13,
angelathe,
JNygaard-Skylight and
austin-hall-skylight
mcmcgrath13
reviewed
Dec 10, 2024
| @@ -49,7 +49,7 @@ export const AccordionLabResults: React.FC<AccordionLabResultsProps> = ({ | |||
| ), | |||
| content: content, | |||
| expanded: collapsedByDefault, | |||
| id: title, | |||
| id: title.replaceAll(/[^a-zA-Z0-9-_:.]/g, "-"), | |||
There was a problem hiding this comment.
we have a helper function for this called toKebabCase - could you use that instead?
mcmcgrath13
reviewed
Dec 10, 2024
| @@ -41,7 +41,7 @@ const EcrSummary: React.FC<EcrSummaryProps> = ({ | |||
| conditionSummary.map((condition) => { | |||
| return { | |||
| title: condition.title, | |||
| id: condition.title.replaceAll(" ", "-"), | |||
| id: condition.title.replaceAll(/[^a-zA-Z0-9-_:.]/g, "-"), | |||
|
@gordonfarrell were you able to re-run the axe test on this to make sure it's appeased? |
|
Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
For lab accordions we were setting the ID to whatever the title was, and the associated aria-controls value to whatever the id was. Because the title was any old string it could contain characters like spaces, commas, ampersand, whatever, that are not valid values for an ID and thus also invalid for aria-controls. Changed how we set the value of the ids to replace any invalid characters with a -
Related Issue
Fixes #2965
Acceptance Criteria
Axe accessibility scans return 0 critical or high severity issues with lab report accordions opened or closed.
Additional Information
Anything else the review team should know?
Checklist