WIP: Add rough draft of SQL to be used in telemetry dashboard #3099
Conversation
akasper
requested review from
angelathe,
austin-hall-skylight,
BobanL,
gordonfarrell,
JNygaard-Skylight,
lina-roth,
mcmcgrath13 and
robertmitchellv
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3099 +/- ##
==========================================
+ Coverage 86.54% 88.54% +1.99%
==========================================
Files 215 82 -133
Lines 13432 4181 -9251
Branches 666 704 +38
==========================================
- Hits 11625 3702 -7923
+ Misses 1798 457 -1341
- Partials 9 22 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
| run_id UUID PRIMARY KEY, -- Unique run ID | ||
| start_time TIMESTAMP NOT NULL, -- Start time of the run | ||
| end_time TIMESTAMP NOT NULL, -- End time of the run | ||
| is_complete BOOLEAN NOT NULL, -- Whether the run completed |
There was a problem hiding this comment.
is this derive-able from lack of end time? or does complete mean something different here (success perhaps)?
| start_time TIMESTAMP NOT NULL, -- Start time of the run | ||
| end_time TIMESTAMP NOT NULL, -- End time of the run | ||
| is_complete BOOLEAN NOT NULL, -- Whether the run completed | ||
| duration INTERVAL GENERATED ALWAYS AS (end_time - start_time) STORED -- Duration of the run |
There was a problem hiding this comment.
what's the thinking on storing this vs computing on the fly?
| set_id VARCHAR(255), -- ID for the set of eICRs | ||
| version_number VARCHAR(50), -- Version number of the eICR within the set |
There was a problem hiding this comment.
should this also or instead of include the ecr_id?
| CREATE INDEX idx_runs_end_time ON runs (end_time); | ||
|
|
||
| CREATE TABLE activity_details ( | ||
| run_id UUID PRIMARY KEY, -- Foreign key to runs table |
There was a problem hiding this comment.
if this is the pk for the runs table also, what's the thinking behind having these be two separate tables?
| CREATE INDEX idx_activity_reportable_condition ON activity_details (reportable_condition); | ||
|
|
||
| CREATE TABLE logging_details ( | ||
| run_id UUID PRIMARY KEY, -- Foreign key to runs table |
There was a problem hiding this comment.
is this necessarily 1:1? could there be more than one error in the pipeline? or maybe its a mismatch of table name vs content - the content seems to be about errors, but logging can be much broader than that
Proof of concept
Summary
Proposed SQL DDL statements for the eCR Viewer dashboard telemetry
Acceptance Criteria
Review discussions and Notion documentation and validate that this schema is sensible.
Additional Information
This is highly subject to change. This code is proof-of-concept only. No need to merge the PR; simply presented for discussion.
Checklist