Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new columns in sample_summary.tsv #25

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Create new columns in sample_summary.tsv #25

merged 7 commits into from
Jun 10, 2024

Conversation

jessicarowell
Copy link
Collaborator

Created 3 new columns:
opxv_reads_1 -> filepath to seqtk output, reads file 1
opxv_reads_2 -> filepath to seqtk output, reads file 2
final_assembly -> filepath to final assembly

Test command:
nextflow run main.nf --indir /scicomp/groups-pure/Projects/scbs_mpob/JRowell_ick4/mpox_testing/paired/ --outdir /scicomp/groups-pure/Projects/scbs_mpob/JRowell_ick4/mpox_testing/results/ --project_name test -config /scicomp/reference/nextflow/configs/cdc-dev.config -profile singularity,rosalind

PR checklist

  • [ x] This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mpxvassembly branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jessicarowell jessicarowell linked an issue May 31, 2024 that may be closed by this pull request
1 task
@mikeyweigand
Copy link
Collaborator

Make sure outputs are full paths to fasta and fastq, even if user input is a relative path.

@jessicarowell
Copy link
Collaborator Author

I've added a line to convert relative to absolute paths for outdir

@jessicarowell
Copy link
Collaborator Author

jessicarowell commented Jun 3, 2024

@mikeyweigand Right now this code only outputs a path for final_assembly if there is a <sample>.final.fa file. If there are only <sample>.draft.fa assemblies, these are ignored and the column is left blank. Is this the expected behavior or should I modify?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Sorry about that...blaming it on Friday. Thanks for fixing it.

@mikeyweigand
Copy link
Collaborator

@mikeyweigand Right now this code only outputs a path for final_assembly if there is a <sample>.final.fa file. If there are only <sample>.draft.fa assemblies, these are ignored and the column is left blank. Is this the expected behavior or should I modify?

Agree this makes the most sense, current 'ask' is to streamline capture of necessary inputs for TOSTADAS, to which you wouldn't send a draft contig fasta.

Copy link
Collaborator

@mikeyweigand mikeyweigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested and performs as expected.

@jessicarowell jessicarowell merged commit b58117e into master Jun 10, 2024
1 of 9 checks passed
@kyleoconnell-CDC kyleoconnell-CDC deleted the issue23 branch September 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal] [Feature] Add full FASTA/FASTQ paths to output summary.tsv
2 participants