Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation ufp0 #38

Merged
merged 44 commits into from
Feb 5, 2025
Merged

Update documentation ufp0 #38

merged 44 commits into from
Feb 5, 2025

Conversation

kyleoconnell
Copy link
Collaborator

PR checklist

I updated the README and the usage documentation.

kyleoconnell-CDC and others added 30 commits July 22, 2024 15:16
…hanges related to making the gfa script able to handle clade I, also added the same logging and summary file present in the original script, but a lot of the script was reorganized and refactored
… comments, added proper spacing, fixed author atribution
…de in the itr for segment order/orientation, 2- updated graph recon submodule and subworkflows to properly name log and summary outputs and pass all channels correctly downstream, 3- fixed summarize qc to align the script with the new format of the log file coming out of graph recon, and to modified the kraken db variable to fix some bug where it wasnt grabbing the kraken-db within the function and writing to final outfile
…f the ITRs. The new version keeps all longest paths, determines the orientations of all paths in the list, then uses quast to find the best alignment with the reference and keep that longest path as the final path under the assumption that the wrongly oriented path will align more poorly."
…s, then selects conneected itrs based on list with terminal itr in it, if there are no connected itrs, then there is 1 itr contig, the terminal itr.
…e case of one long contig and only an ITR, as well as handle broken (non cyclical) sequences
@kyleoconnell kyleoconnell self-assigned this Jan 29, 2025
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @kyleoconnell,

It looks like this pull-request is has been made against the CDCgov/polkapox master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the CDCgov/polkapox dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@kyleoconnell kyleoconnell changed the base branch from master to dev January 29, 2025 20:53
@kyleoconnell
Copy link
Collaborator Author

nextflow run main.nf -profile test,singularity

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking - does this empty file belong here?

@mikeyweigand
Copy link
Collaborator

mikeyweigand commented Feb 5, 2025

@kyleoconnell Do we need to update docs/images/bandage_polkapox.png based on your updates to the reconstruction algorithm? Can you scribble something?

Similar question for the unresolvable examples. Any additions needed?

@jessicarowell jessicarowell merged commit b796e2c into dev Feb 5, 2025
0 of 2 checks passed
@jessicarowell jessicarowell deleted the update_docs_kao branch February 5, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants