Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

fix for size data is missing from output report #4 #5

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

pdurbin
Copy link
Contributor

@pdurbin pdurbin commented Jan 30, 2019

@sfisher hi! It was a pleasure speaking with you the other week. Thanks for opening #4 about size/volume being missing from the JSON report. As we discussed, even if DataCite doesn't accept the size yet, for Dataverse we plan to process the JSON files created by Counter Processor and save the metrics in our database (diagram below) so we're interested in support for size. The fix is simply uncommenting some code you already wrote. Thank you!

mdc-arch

The issue we're using on our side is IQSS/dataverse#4821

@sfisher
Copy link
Contributor

sfisher commented Jan 30, 2019

Thanks Phil and Matthew,

Looks good. I'm merging this in.

It looks like there are a couple of security vulnerabilities in python libraries, so I'll update these couple of libraries and create another release version soon, also.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants