This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
fix for size data is missing from output report #4 #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sfisher hi! It was a pleasure speaking with you the other week. Thanks for opening #4 about size/volume being missing from the JSON report. As we discussed, even if DataCite doesn't accept the size yet, for Dataverse we plan to process the JSON files created by Counter Processor and save the metrics in our database (diagram below) so we're interested in support for size. The fix is simply uncommenting some code you already wrote. Thank you!
The issue we're using on our side is IQSS/dataverse#4821