Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes for create IDs pages #816

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sfisher
Copy link
Contributor

@sfisher sfisher commented Jan 3, 2025

For both the simple and advanced pages. See #544 .

I had to do quite a bit of HTML and CSS redoing and rearranging to make the order right for screen readers (or pressing tab through all the fields).

The ordering issues.

  • Before, the entire form was in-between the simple and advanced tabs in the form.
  • The PDFs sidebar was first and they wanted it to go to the end after all the form. This was wonky because the top half of the form is a two column layout (choose an ID and quick start) and the bottom half of the form was a full width full column layout. So either the PDFs were before the entire form or else they'd appear in the middle of the form tab order if doing columns in any normal order. I finally had to do some floats and move things around and do absolute positioning of the PDF/guides to make the source code/tab order be nice for screen readers while looking the same. (I also had to manually simulate the bootstrap widths and columns with css since couldn't get bootstrap to do what I needed.) 🤷‍♂️

…b mechanism that puts them in correct order.
…n order to put tabs one after the other and in correct order and matching layout.
…e crazy stuff to imitate the bootstrap layout which seems impossible to put that column last the way it's arranged.
…ing PDFs to the end when they actually appear in a weird box in the top-right rather than having a real column.
@sfisher sfisher linked an issue Jan 3, 2025 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility fixes: Create ID
1 participant