Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Consecutive WebSocket Reconnects #128

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

jacob6838
Copy link
Collaborator

PR Details

Description

Fixing a bug causing consecutive long-interval live intersection (STOMP websocket) reconnects to fail. The live intersection STOMP websocket handler is set to re-connect after onDisconnect and onClose. This is limited to 5 re-connects if the re-connects happen in quick succession (<10 seconds), and unlimited for longer re-connects (CDOT commonly re-connects after 30 seconds). This was causing a bug where the second 30-second re-connect would not be triggered correctly. This has been resolved.

How Has This Been Tested?

This has been tested locally

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • All existing tests pass.

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit 2b86aad into develop Dec 16, 2024
10 checks passed
@payneBrandon payneBrandon deleted the live-timeout-fix branch December 16, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants