Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock In Python 3.12.2 #44

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Lock In Python 3.12.2 #44

merged 6 commits into from
Mar 11, 2024

Conversation

dmccoystephenson
Copy link
Member

Problem

The version of python to be used with the project is not locked in. The dockerfiles use 3.12.0, the CI uses 3.9 & the developer may choose to use another version as the documentation does not guide the developer on this.

Solution

The latest LTS version of Python, v3.12.2, has been locked in via the following:

  1. The README now recommends using Python 3.12.2
  2. The dockerfiles use Python 3.12.2
  3. The CI uses Python 3.12.2
  4. Instructions on setting up a virtual environment have been added to the README.

Testing

  • The unit tests have been verified to work with these changes.
  • The dockerfiles have been verified to build with these changes.

Copy link
Collaborator

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running unit tests in the python 3.12.2 virtual environment I ran into a segmentation fault when a test with the 'with patch(...)' syntax was encountered. I'm curious if this is happening for anyone else or if this is just an issue with my machine. When unit tests are run locally with python 3.12.2 they're all working correctly.

I had one question about documentation - otherwise looks great! Spins up correctly when run locally.

README.md Outdated Show resolved Hide resolved
@dmccoystephenson
Copy link
Member Author

dmccoystephenson commented Mar 3, 2024

When running unit tests in the python 3.12.2 virtual environment I ran into a segmentation fault when a test with the 'with patch(...)' syntax was encountered. I'm curious if this is happening for anyone else or if this is just an issue with my machine. When unit tests are run locally with python 3.12.2 they're all working correctly.

I have encountered this error before, but it was when running the unit tests locally with Python 3.12. I did not run into this error when testing these changes, however, so it appears to be intermittent.

Which unit test in particular is failing? We may want to consider moving away from the 'with path(...)' syntax if this is the cause of the error.

@dmccoystephenson dmccoystephenson requested a review from mwodahl March 3, 2024 22:17
Copy link
Collaborator

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mwodahl
Copy link
Collaborator

mwodahl commented Mar 6, 2024

When running unit tests in the python 3.12.2 virtual environment I ran into a segmentation fault when a test with the 'with patch(...)' syntax was encountered. I'm curious if this is happening for anyone else or if this is just an issue with my machine. When unit tests are run locally with python 3.12.2 they're all working correctly.

I have encountered this error before, but it was when running the unit tests locally with Python 3.12. I did not run into this error when testing these changes, however, so it appears to be intermittent.

Which unit test in particular is failing? We may want to consider moving away from the 'with path(...)' syntax if this is the cause of the error.

For me all of the unit tests using the with patch(...) syntax were resulting in a segmentation fault. I'm not sure if this is something that would require an additional work item as I am able to run the tests fine locally but might be worth looking into if others encounter this error.

@payneBrandon payneBrandon merged commit 304015c into develop Mar 11, 2024
9 checks passed
@payneBrandon payneBrandon deleted the python/lock-in-lts-version branch March 11, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants