-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock In Python 3.12.2 #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running unit tests in the python 3.12.2 virtual environment I ran into a segmentation fault when a test with the 'with patch(...)' syntax was encountered. I'm curious if this is happening for anyone else or if this is just an issue with my machine. When unit tests are run locally with python 3.12.2 they're all working correctly.
I had one question about documentation - otherwise looks great! Spins up correctly when run locally.
I have encountered this error before, but it was when running the unit tests locally with Python 3.12. I did not run into this error when testing these changes, however, so it appears to be intermittent. Which unit test in particular is failing? We may want to consider moving away from the 'with path(...)' syntax if this is the cause of the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
For me all of the unit tests using the with patch(...) syntax were resulting in a segmentation fault. I'm not sure if this is something that would require an additional work item as I am able to run the tests fine locally but might be worth looking into if others encounter this error. |
Problem
The version of python to be used with the project is not locked in. The dockerfiles use 3.12.0, the CI uses 3.9 & the developer may choose to use another version as the documentation does not guide the developer on this.
Solution
The latest LTS version of Python, v3.12.2, has been locked in via the following:
Testing