Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode improvements #473

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Dark mode improvements #473

merged 4 commits into from
Jan 17, 2024

Conversation

calc84maniac
Copy link
Contributor

Improve dark mode support in the following ways:

  • Support dark theme on Windows Qt6 by switching to Fusion style if applicable
  • Improve detection of the current theme in an OS-independent way
  • Detect system theme changes dynamically and update colors to match
  • Improve dark mode color contrast in various areas of the UI
  • Switch to a syntax highlighter for the disassembly view rather than hardcoding HTML, making it easier to style

I'm going ahead and putting up a PR to generate builds for feedback, and to get some testing on MacOS and Linux since I've only been able to test on Windows. In the meantime I may want to look into improving the Fusion style slightly, because some aspects of it seem a little off layout-wise.

@adriweb
Copy link
Member

adriweb commented Jan 13, 2024

I tested both Qt5 and Qt6 macOS builds, and so far it's good:

image

@adriweb
Copy link
Member

adriweb commented Jan 17, 2024

More tests:

  • On Qt6: looks perfect on the Qt6 version. It adjusts automatically when the system pref changes.
  • On Qt5: it is fine after you do a run/stop cycle, for the disasm to be showing with the new colors. So it's really not a big problem.

@adriweb adriweb merged commit 5494d4e into master Jan 17, 2024
5 checks passed
@adriweb adriweb deleted the dark-mode-improvements branch January 17, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants