Including ti84pce.h in multiple files causes linktime warnings.

[elfprince13]

If I #include <ti84pce.h> in multiple files, at link time, the object files for some of them emit duplicate symbol warnings for __frameset:

WARNING (909) (00000000 rb_tree\misc.obj)--> Public symbol "__frameset" already externally defined.
WARNING (909) (00D1D3EE rb_tree\misc.obj)--> Public symbol "__frameset" already externally defined.

If I rewrite these later files with #pragma asm to provide equates for only the labels I need, the warning is not emitted.

[adriweb]

Tagging this as an external issue until proven otherwise, as include guards are already present, so I'm not sure what to do about it...

[debrouxl]

Include guards protect against multiple inclusion of a given header during a single compiler invocation, but they're powerless against single or multiple inclusion of a given header during multiple independent compiler invocations.
Now, why exactly is the toolchain complaining about __frameset specially, which is an equate in the ASM file included by ti84pce.h, I don't know.

[adriweb]

Oh, yeah, "multiple independent compiler invocations", you're probably right...

[jacobly0]

WARNING (909) (00000000 Z:\opt\CEdev\lib\std\chelp.lib)--> Public symbol "__imuls" already externally defined.
WARNING (909) (00D1CEC1 Z:\opt\CEdev\lib\std\chelp.lib)--> Public symbol "__imuls" already externally defined.

I believe this is related.

[elfprince13]

Perhaps turning the equates into a mix of defines and xrefs would help?

[elfprince13]

I think "external issue" is not the right tag for this. It's not a compiler issue, it's a "the include file doesn't behave like an include file, because it introduces link-time symbols, rather than merely providing forward declarations" issue.

[adriweb]

Yeah, removed it.

[mateoconlechuga]

Just use _At rather than equ.

[mateoconlechuga]

The best solution would be to redo the standard libraries to use the libraries in the bootcode. This probably means modifying the crtl source so it doesn't cause these warnings.

[mateoconlechuga]

Fixed with release v2.0 (And no, changing the name to 'tice.h' wasn't the solution :P)