Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimised _PrintUInt & _FillScreen #40

Merged
merged 2 commits into from Nov 7, 2016
Merged

optimised _PrintUInt & _FillScreen #40

merged 2 commits into from Nov 7, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 7, 2016

Slight optimisation of _PrintUInt,
Propose to include a faster fillscreen when color is null

Gérald DeGroote added 2 commits November 7, 2016 11:11
Slight optimisation of _PrintUInt,
Propose to include a faster fillscreen when color is null
Copy link
Member

@mateoconlechuga mateoconlechuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _FillScreen isn't an optimization.

@@ -1983,13 +1991,13 @@ _ClipDraw_ASM:
; DE : New X coordinate
; NC : If offscreen
ld ix,6 ; get pointer to arguments
ld iy,ix-6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't exist :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to merge anyway and fix myself

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I meant LEA iy,ix-6 ;)

@mateoconlechuga mateoconlechuga merged commit 2e7664d into CE-Programming:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants