Skip to content

Conversation

ZERICO2005
Copy link
Contributor

@ZERICO2005 ZERICO2005 commented Oct 19, 2025

Fixed the white-space in GraphX (changing ld hl,(ix+9) to ld hl, (ix + 9)). This should allow the git history to be cleaner.

Additionally, I added .git-blame-ignore-revs, this allows the whitespace changes to be ignored when using git-blame.

Whenever I edit GraphX code, I tend to also fix the white-space for that function too, which can make it harder to review what lines of code were actually changed.

Copy link
Member

@runer112 runer112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about .git-blame-ignore-revs, neat.

A note for you freaks who love squash or rebase "merging": Those methods will invalidate the changes in .git-blame-ignore-revs in this PR.

Another score for real merging.

@adriweb
Copy link
Member

adriweb commented Oct 21, 2025

lol let's just use fast-forward only "merging" so that a cursed merged commit doesn't pollute the history 😎

@ZERICO2005
Copy link
Contributor Author

ZERICO2005 commented Oct 21, 2025

I think it would be best to merge #659 first before this PR.
Then I can I will rebase onto that and update the commit hash to ignore.
Actually nevermind. Probably merge this before #659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants