-
-
Notifications
You must be signed in to change notification settings - Fork 63
fixed whitespace in graphx #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
57bd136
to
7619f84
Compare
7619f84
to
047098a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know about .git-blame-ignore-revs, neat.
A note for you freaks who love squash or rebase "merging": Those methods will invalidate the changes in .git-blame-ignore-revs in this PR.
Another score for real merging.
lol let's just use fast-forward only "merging" so that a cursed merged commit doesn't pollute the history 😎 |
Fixed the white-space in GraphX (changing
ld hl,(ix+9)
told hl, (ix + 9)
). This should allow the git history to be cleaner.Additionally, I added
.git-blame-ignore-revs
, this allows the whitespace changes to be ignored when using git-blame.Whenever I edit GraphX code, I tend to also fix the white-space for that function too, which can make it harder to review what lines of code were actually changed.