Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the incompatibilities with the different python version #73

Merged
merged 4 commits into from
Nov 20, 2019
Merged

Fixing the incompatibilities with the different python version #73

merged 4 commits into from
Nov 20, 2019

Conversation

LElgueddari
Copy link
Contributor

This solves issue #72, it checks the python version and imports the right function

@coveralls
Copy link

coveralls commented Nov 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 211

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 94.378%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modopt/math/metrics.py 4 5 80.0%
modopt/tests/test_math.py 4 5 80.0%
Totals Coverage Status
Change from base Build 198: -0.08%
Covered Lines: 1729
Relevant Lines: 1832
💛 - Coveralls

@sfarrens sfarrens self-requested a review November 19, 2019 10:31
@sfarrens sfarrens added the bug label Nov 19, 2019
sfarrens
sfarrens requested changes Nov 19, 2019
View reviewed changes
modopt/math/metrics.py Outdated Show resolved Hide resolved
modopt/tests/test_math.py Outdated Show resolved Hide resolved
@LElgueddari LElgueddari requested a review from sfarrens November 19, 2019 15:42
@sfarrens sfarrens merged commit 058401c into CEA-COSMIC:master Nov 20, 2019
@sfarrens sfarrens mentioned this pull request Nov 20, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfarrens sfarrens sfarrens approved these changes

Assignees

@LElgueddari LElgueddari

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LElgueddari @coveralls @sfarrens