Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linear Composition #83

Closed
wants to merge 1 commit into from
Closed

Fix Linear Composition #83

wants to merge 1 commit into from

Conversation

chaithyagr
Copy link
Contributor

This PR handles fixes for #81

@chaithyagr chaithyagr requested a review from sfarrens January 31, 2020 16:31
@chaithyagr chaithyagr self-assigned this Jan 31, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 235

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.85%
Totals Coverage Status
Change from base Build 233: 0.0%
Covered Lines: 1897
Relevant Lines: 2000
💛 - Coveralls

zaccharieramzi
zaccharieramzi suggested changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@zaccharieramzi zaccharieramzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in https://github.com/CEA-COSMIC/ModOpt/issues/81

@chaithyagr
Copy link
Contributor Author

Based on #81, we know for sure that this update to codes is not right at all, closing it here.

@chaithyagr chaithyagr closed this Feb 3, 2020
@chaithyagr chaithyagr deleted the fix_linear_comp branch February 4, 2020 14:26
@sfarrens sfarrens added the bug label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaccharieramzi zaccharieramzi zaccharieramzi requested changes

@sfarrens sfarrens Awaiting requested review from sfarrens

Assignees

@chaithyagr chaithyagr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaithyagr @coveralls @zaccharieramzi @sfarrens