Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generic step_size parameter to algorithm SetUp #89

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

sfarrens
Copy link
Contributor

@sfarrens sfarrens commented Feb 6, 2020

  • Added step_size parameter to SetUp class.
  • Made conditional assignment for step size parameters in each algorithm.
  • Added unit test using step_size parameter.

@sfarrens sfarrens self-assigned this Feb 6, 2020
@sfarrens sfarrens linked an issue Feb 6, 2020 that may be closed by this pull request
2 tasks
@coveralls
Copy link

coveralls commented Feb 6, 2020

Pull Request Test Coverage Report for Build 255

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 94.033%

Totals Coverage Status
Change from base Build 245: 0.01%
Covered Lines: 1891
Relevant Lines: 2011

💛 - Coveralls

@sfarrens
Copy link
Contributor Author

@chaithyagr @zaccharieramzi any comments on this before I merge?

Copy link
Contributor

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just minor concern is that you may need to mention which takes precedence if both are specified, in this case it is step_size.
But as I say, it is Minor

@sfarrens
Copy link
Contributor Author

LGTM.
Just minor concern is that you may need to mention which takes precedence if both are specified, in this case it is step_size.
But as I say, it is Minor

Good point, it's always better to be explicit. I will add something to the API documentation to make this clear.

@sfarrens sfarrens merged commit 7d0f82d into CEA-COSMIC:master Feb 11, 2020
@sfarrens sfarrens deleted the step_size branch February 11, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QoL] Consistent naming scheme for step size parameters in FB/GFB
3 participants