Ceed*Get[CeedObject] Needs Destroy #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
force-pushed
the
jeremy/get-ceed-object
branch
5 times, most recently
from
dc369e7
to
1792040
Compare
jeremylt
force-pushed
the
jeremy/get-ceed-object
branch
from
7910856
to
dc3318a
Compare
|
Is MFEM going to need updates to track this? |
jedbrown
approved these changes
Oct 23, 2024
|
Surprisingly, the updates MFEM needs for v0.13 are pretty minimal. I've got a branch open, and I don't think this PR will add any new changes. But Ratel and HONEE will need a couple of changes |
jedbrown
reviewed
Oct 23, 2024
jedbrown
reviewed
Oct 23, 2024
Comment on lines
2088
to
+2091
| let mut ptr_coarse = std::ptr::null_mut(); | ||
| let mut ptr_prolong = std::ptr::null_mut(); | ||
| let mut ptr_restrict = std::ptr::null_mut(); | ||
| let ierr = unsafe { | ||
| self.op_core.check_error(unsafe { |
There was a problem hiding this comment.
In the future (definitely a different PR), this could be let (op_coarse, op_prolong, op_restrict) = ceed.op_core.check_error_with_3(|ptr_coarse, ptr_prolong, ptr_restrict| unsafe { ... })?;.
Note that Operator::from_raw should be unsafe because it will dereference a raw pointer. Just noticed that while browsing (also not for this PR, and I'm not trying to snipe you into working on it).
|
@jrwrigh this is relevant to HONEE - you'll want a couple of Destroys probably |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring Ceed objects returned from
Ceed*Get[CeedObject]to be destroyedCeed*GetCeedCeedGetParentCeedGetDelegateCeedGetObjectFallbackCeedGetOperatorFallbackCeedCeedQFunctionGetContextCeedOperatorGetQFunctionCeedOperatorGetFallbackParentCeed