Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug in install.sh #162

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Minor bug in install.sh #162

merged 2 commits into from
Feb 22, 2024

Conversation

ilhamv
Copy link
Member

@ilhamv ilhamv commented Feb 21, 2024

At some point, we accidentally removed install from conda install mpi4py.
Is it possible to test install.sh as part of the github workflow?

@jpmorgan98
Copy link
Collaborator

jpmorgan98 commented Feb 21, 2024

Yes that's a great idea! I changed the PR base to dev instead of main

@jpmorgan98 jpmorgan98 added the bug Something isn't working as intended label Feb 21, 2024
@jpmorgan98 jpmorgan98 changed the base branch from main to dev February 21, 2024 17:20
@ilhamv ilhamv merged commit 591689e into CEMeNT-PSAAP:dev Feb 22, 2024
6 checks passed
@lewisfish lewisfish mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants