Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geometry #244

Open
wants to merge 35 commits into
base: dev
Choose a base branch
from
Open

Update geometry #244

wants to merge 35 commits into from

Conversation

ilhamv
Copy link
Member

@ilhamv ilhamv commented Oct 4, 2024

  • Implement universe cell
  • Reimplement the continuously moving surface. Verified on moving planar surfaces. Need verification for quadratic surfaces (next PR).
    • The user interface changes: see C5G7-TDX in examples and moving pellet test in test/regression interface (next PR will update the docs)
    • The new implementation supports moving quadric surfaces too (still need verification).
  • Major refactoring on geometry-related functions.
  • Temporarily remove caching. The current Numba caching mechanics does not work with the refactoring of kernel functions into submodules. We had a plan to reimplement more robust caching mechanics. So, rather than trying to fix the caching mechanics that were soon to be replaced, we removed the caching option altogether and will work on the plan in the next PR.

@ilhamv ilhamv marked this pull request as draft October 4, 2024 08:17
@ilhamv ilhamv added the enhancement New feature or request label Oct 4, 2024
@ilhamv ilhamv added this to the v0.12 milestone Oct 4, 2024
@ilhamv ilhamv requested a review from clemekay October 11, 2024 22:30
@clemekay clemekay marked this pull request as ready for review October 11, 2024 22:33
@clemekay clemekay marked this pull request as draft October 11, 2024 22:33
@ilhamv
Copy link
Member Author

ilhamv commented Oct 12, 2024

The iQMC Numba tests failed... But they passed on my local machine... Can you please check if they pass on your end, @clemekay? Thanks!

@clemekay
Copy link
Collaborator

clemekay commented Oct 14, 2024

I cloned your update-geometry branch on Dane, created a fresh MC/DC install from it, checked out an interactive node, and executed python run.py --mode=numba from MCDC/test/regression/. The four iqmc tests that failed on github (iqmc_cooper2, iqmc_kornreich_pi, iqmc_reed, and iqmc_sood_pi) also failed for me with a Segmentation fault.

Interestingly, I originally accidentally ran the tests before executing bash patch_numba.sh and test iqmc_sood_pi passed, but it failed after patching numba. This is my pip list, do all of these versions match what you've got locally?

Screenshot 2024-10-14 at 12 06 19 PM

@ilhamv
Copy link
Member Author

ilhamv commented Nov 5, 2024

The recent merge of dev has the planned caching capabilities per #250.

@ilhamv ilhamv marked this pull request as ready for review November 6, 2024 05:12
@ilhamv ilhamv requested a review from clemekay November 6, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants